Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Orientation/Motion Overhaul PR #24

Closed
wants to merge 22 commits into from

Conversation

John-Bonnin
Copy link
Contributor

Already changed orientations. Working on speed controls to prevent rapid movements for safety, and methods of defining desired motion policy. #23

John-Bonnin and others added 17 commits September 15, 2022 17:16
…rame or tcp position arent tested yet and may be dangerous. Orientation and changes thereof come next. Currently TCP and target frame are 180 degrees about X from each other, which will cause problems later. Will try to remove.
…Sam Spade. We investigated a dastardly communication bottleneck which was dropping data packets willy-nilly. Found the culprit lurking in opt/ros/noetic, the ur-client-library. It was ancient, a cluster of hoary shambling debs from more than a year ago. Ousting them in favor of a shiny build-from-source gave the diamonds back to the rightful dame. Goodnight, sweetheart.
…sures from Conntext (working on a new commit to add these properly); changed ros_conntact_interface so you can draw config files from a different package than Conntact by passing the package name to the Interface at startup.
…oller gains to start some hardening with the new speeds allowed by our improved testing hardware.
…delay from state-change detection which has been there the whole time :| . It would gain confidence *from zero* up to the threshold before starting the timer, which would require (threshold) seconds to do since we devide by the cycle rate. Fixed it; however now exitThreshold is not accurate (not that anybody cares much). Values from .1 to 1 will map from about 50% to about 90%.
…ended spiral search hole detection time; increased motion gains.
…n commands next. To avoid breaking backward-compatibility and because quaternions are terrible, next step will be to change pose_vec (the general list format of pose, orientation command passed around) to use euler angles. If a 4-element list (quaternion) is passed in, it will automatically be replaced with a 0,0,0 rotation for safety.
…ning with four MoveModes for linear, planar, set, or free motion. Validated with pyplot unit tests. Trying on hardware next by substituting it in for pose_vec and arbitrary_axis_comply functions.
… the call stack to send movement commands - ConnTask now just asks ConnText to move according to current_step.current_move(current_position), which flattens the formerly 5-deep call chain to about 1 line. Much better. Backward compatability is broken; working on a solution to automatically detect when a third-party ConnTask defines its motions in the old way and automatically transcribe the inputs to the move_policy scheme.
…right after step creation; removed update_commands from execute method completely! Cleanup of dead code still pending.
@John-Bonnin John-Bonnin marked this pull request as draft October 26, 2022 20:28
@John-Bonnin John-Bonnin closed this Nov 2, 2022
@John-Bonnin John-Bonnin deleted the devel branch November 2, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant